opengnb: add opengnb 1.6.8 to openwrt - #29879

Pull request overview

Adds the opengnb package to the OpenWrt packages feed at version 1.6.5, enabling users to build/install OpenGNB (P2P decentralized virtual network/VPN) from the feed.

Changes:

• Introduces net/opengnb/Makefile defining the new package metadata, source fetch, and build/install steps.
• Builds OpenGNB using the upstream Makefile.openwrt and installs gnb, gnb_crypto, and gnb_ctl into /usr/sbin.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Reviewed 2 new commits. CI (FormalityCheck) passes on the head commit; the earlier natpmpc test failures were resolved by dropping the miniupnpc/libnatpmp dependencies in the 1.6.6 update. Commit messages match their diffs. Two minor nits inline (file mode, series hygiene); no blocking issues found.

Generated by Claude Code

Reviewed 1 new commit; no new issues found. The two prior nits are resolved: the Makefile is now committed with mode 100644, and history was squashed into a single opengnb: add version 1.6.6 commit with the PR title/description updated to match PKG_VERSION. FormalityCheck CI passes on the head commit.

Generated by Claude Code

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

define Build/Compile
	$(MAKE) -C $(PKG_BUILD_DIR) \
		$(TARGET_CONFIGURE_OPTS) \
		CFLAGS="$(TARGET_CFLAGS) -I. -I./src -I./libs -I$(STAGING_DIR)/usr/include -DWITHOUT_MINIUPNPC -D_GNU_SOURCE -DNO_GZIP=1 -DGNB_OPENWRT_BUILD=1" \
		LDFLAGS="$(TARGET_LDFLAGS) -L$(STAGING_DIR)/usr/lib -lz -pthread" \

Reviewed 1 new commit (385836d), which replaces the previously reviewed 1.6.6 state with 1.6.7.

What I verified as correct:

• PKG_HASH matches the upstream opengnb-1.6.7.tar.gz release asset (c2e4aa17…f0443), and PKG_RELEASE:=1 is right for a version bump.
• The Build/Compile simplification holds up. 1.6.7's Makefile.openwrt now sets GNB_CFLAGS=$(CFLAGS) -I./src -I./libs -D_GNU_SOURCE -DNO_GZIP=1 -DWITHOUT_MINIUPNPC -DGNB_OPENWRT_BUILD=1 itself, so dropping those flags here is not a behaviour change, and -DWITHOUT_MINIUPNPC is still applied — the missing miniupnpc/libnatpmp dependencies stay correct.
• Dropping the explicit all goal is safe: all is the first target in Makefile.openwrt and the included Makefile.openwrt.inc defines only variables, no rules, so all remains the default goal.
• Removing -I$(STAGING_DIR)/usr/include / -L$(STAGING_DIR)/usr/lib is fine — $(TARGET_CPPFLAGS) and $(TARGET_LDFLAGS) already carry them. Dropping -lz -pthread from LDFLAGS is also fine: upstream adds them on the gnb and gnb_es link lines, and gnb_ctl / gnb_crypto pull in neither zlib nor pthread. This addresses the earlier Copilot remark on the flag handling.
• The commit message matches its diff.

Two substantive findings inline: gnb_es is linked without $(TARGET_LDFLAGS) because upstream shadows it with GNB_ES_LDFLAGS, so that binary ships without OpenWrt's hardening/linker flags; and all four binaries embed __DATE__/__TIME__, which upstream lets you switch off with a single define. I'd call the gnb_es link the one worth fixing before merge; the timestamp one is a reproducibility improvement rather than a blocker. The other two comments are optional nits.

On CI: only FormalityCheck has reported on this head commit and all three of its checks are green. The multi-arch test build has not posted a result yet, so there is nothing to read into it either way.

Generated by Claude Code

Reviewed 1 new commit (6d18701), which replaces the previously reviewed 1.6.7 state with 1.6.8. Nothing blocking; one optional cosmetic nit inline.

What I verified:

• PKG_HASH:=4c6a6030…f829 matches the upstream opengnb-1.6.8.tar.gz release asset (downloaded and hashed independently), and PKG_RELEASE:=1 is correct for a version bump.
• Both substantive findings from my 1.6.7 review are fixed upstream in 1.6.8, so no change is needed in this Makefile for either. Makefile.openwrt now reads GNB_ES_LDFLAGS=$(LDFLAGS) (was -Wl,--gc-sections), so gnb_es finally links with $(TARGET_LDFLAGS) like the other three binaries; and GNB_CFLAGS gained -DGNB_SKIP_BUILD_TIME=1, so none of the four binaries embeds __DATE__/__TIME__ any more (src/gnb_version.h now resolves GNB_BUILD_STRING to "Build Time [Hidden]"). The two corresponding inline threads from the last review are stale and can be resolved.
• The full 1.6.7 → 1.6.8 upstream diff is confined to the per-platform Makefile.*, src/gnb_version.h and version — no new sources and no new library usage — so DEPENDS:=+kmod-tun +libpthread +zlib is still accurate: gnb still links -lz -pthread, and -DWITHOUT_MINIUPNPC is still set, so the miniupnpc/libnatpmp dependencies stay correctly absent.
• Omitting an explicit make goal is still safe: all remains the first target in Makefile.openwrt, and Makefile.openwrt.inc still defines only object-list variables, no rules.
• The commit message matches its diff, carries a Signed-off-by, and the file is committed with mode 100644.

CI: the three FormalityCheck jobs are green on the head commit. The multi-arch test build has not reported on this commit yet, so there is nothing to read into it either way.

Still open from the previous round: the question about whether a procd init script (/etc/init.d/opengnb) and a UCI config are planned, since gnb is a long-running daemon and the package currently installs binaries only. That thread has not been answered.

Generated by Claude Code

Reviewed 1 new commit (403d211); no new issues found.

The only change since the previously reviewed state is the cosmetic alignment nit from my last round: the LDFLAGS="$(TARGET_LDFLAGS)" continuation line now pads with a single space like the three lines around it, so the whole Build/Compile block is consistent. Nothing else in net/opengnb/Makefile moved — PKG_VERSION/PKG_RELEASE/PKG_HASH, DEPENDS, the recipe body and the install block are byte-identical to what I verified at 1.6.8, the file is still committed with mode 100644, and the commit subject matches its diff.

Housekeeping on the older inline threads, so the list reflects reality:

• The gnb_es / $(TARGET_LDFLAGS) thread and the __DATE__/__TIME__ reproducibility thread are both stale — 1.6.8 fixes each upstream (GNB_ES_LDFLAGS=$(LDFLAGS) and -DGNB_SKIP_BUILD_TIME=1 in Makefile.openwrt), so no change is needed here. They can be resolved.
• Still unanswered from two rounds ago: whether a procd init script (/etc/init.d/opengnb) and a UCI config are planned. gnb is a long-running daemon and the package currently installs binaries only, so nothing starts it at boot. Not a blocker for an initial submission if that is the intent — it would just be good to say so on the record.

Generated by Claude Code